fix(x/precisebank): Ensure exact reserve balance on integer carry when minting #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddeluca
reviewed
Jun 14, 2024
pirtleshell
approved these changes
Jun 17, 2024
Comment on lines
+172
to
+179
| // Mint an additional reserve integer coin if remainder is insufficient. | ||
| // The remainder is the amount of fractional coins that can be minted and | ||
| // still be fully backed by reserve. If the remainder is less than the | ||
| // minted fractional amount, then the reserve needs to be increased to | ||
| // back the additional fractional amount. | ||
| // Optimization: This is only done when the integer amount does NOT carry, | ||
| // as a direct account mint is done instead of integer carry transfer + | ||
| // insufficient remainder reserve mint. |
There was a problem hiding this comment.
appreciate this detailed explanation 👍
Must be exact, not insufficient nor excessive
…ead of mint Previously to this change, reserve would get an extra mint if the fractional balance is rolled over to integers. This is because its both minted when carried and when reserve remainder is insufficient
drklee3
force-pushed
the
dl-precisebank/mint-reserves-fix
branch
from
f09ef1d
to
b071b0e
Compare
pirtleshell
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description