Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support CLI completion #2017

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat(cli): support CLI completion #2017

merged 1 commit into from
Sep 6, 2024

Conversation

pirtleshell
Copy link
Member

Description

enables the underlying cobra CLI completion scripts.

supported shells:

  • Bash
  • Zsh
  • Fish
  • PowerShell

this replaces (and un-hides) the previously-existing tendermint completion command that only supported bash & zsh.

see kava completion <shell> --help for specifics

❯ kava completion --help
Generate the autocompletion script for kava for the specified shell.
See each sub-command's help for details on how to use the generated script.

Usage:
  kava completion [command]

Available Commands:
  bash        Generate the autocompletion script for bash
  fish        Generate the autocompletion script for fish
  powershell  Generate the autocompletion script for powershell
  zsh         Generate the autocompletion script for zsh

Checklist

  • Changelog has been updated as necessary.

@pirtleshell
feat(cli): support CLI completion
498935b 
enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics
nddeluca
nddeluca approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@nddeluca nddeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, tested with zsh & bash on debian

@pirtleshell pirtleshell merged commit 8ac4c5d into master Sep 6, 2024
12 checks passed
@pirtleshell pirtleshell deleted the rp-cli-completion branch September 6, 2024 18:58
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
@pirtleshell @mergify
feat(cli): support CLI completion (#2017)
cf7c6d6 
enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics

(cherry picked from commit 8ac4c5d)

# Conflicts:
#	CHANGELOG.md
#	cmd/kava/cmd/root.go
@mergify mergify bot mentioned this pull request Sep 6, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nddeluca nddeluca nddeluca approved these changes

@rhuairahrighairidh rhuairahrighairidh Awaiting requested review from rhuairahrighairidh rhuairahrighairidh is a code owner

@karzak karzak Awaiting requested review from karzak karzak is a code owner

@drklee3 drklee3 Awaiting requested review from drklee3 drklee3 is a code owner

@DracoLi DracoLi Awaiting requested review from DracoLi DracoLi is a code owner

@evgeniy-scherbina evgeniy-scherbina Awaiting requested review from evgeniy-scherbina evgeniy-scherbina is a code owner

@sesheffield sesheffield Awaiting requested review from sesheffield sesheffield is a code owner

@boodyvo boodyvo Awaiting requested review from boodyvo boodyvo is a code owner

@lbayas lbayas Awaiting requested review from lbayas lbayas is a code owner

Assignees
No one assigned
Labels
A:backport/v0.26.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirtleshell @nddeluca