Add cli support for new bip44 coin type #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karzak
approved these changes
Feb 7, 2020
denalimarsh
pushed a commit
that referenced
this pull request
Apr 3, 2020
* first attempt * refactor, add tests * update comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: cli defaults to the new coin type, and adds support for the old through a flag
--legacy-hd-path.Turns out only the
keys addcmd needed changing, since once you've added a key all the information (the bip44) is stored with it so other cmds don't need access to the global coin type var.This code monkey patches the sdk code which is kind of janky. For cdp mainnet we could rewrite the sdk keys cmd since it's not great to begin with.
Hold off merge until I've written some docs.