Add raw params querier #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix conflicts before merge. With each PR now containing a changelog entry we're unfortunately gonna have a lot of these conflicts in CHANGELOG.md. |
denalimarsh
approved these changes
Jun 18, 2020
To avoid this, the merging author/reviewer should update the changelog right before merging. |
karzak
pushed a commit
that referenced
this pull request
Jul 7, 2020
* add raw-params cmd * add querier test * update changelog
karzak
pushed a commit
that referenced
this pull request
Jul 7, 2020
* add raw-params cmd * add querier test * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a querier and cli method to retrieve raw param
[]bytevalues.This makes it easier to compare current param values with governance proposals and verify there are no mistakes. Should be useful if we need to create proposals quickly in emergency scenarios.
Ideally this would live in the sdk params module, but we don't have access, so I put it in the committee module as it has access to the params keeper.
Could add a rest endpoint, but I couldn't think of a use case, so left it just as a cli cmd.