Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check correct time elpased condition #853

Merged
merged 1 commit into from
Feb 24, 2021
Merged

fix: check correct time elpased condition #853

merged 1 commit into from
Feb 24, 2021

Conversation

karzak
Copy link
Member

@karzak karzak commented Feb 24, 2021

Time elapsed was checking

(start.After(previousAccrualTime))
  • should be checking against the current block time

denalimarsh
denalimarsh approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@denalimarsh denalimarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karzak karzak merged commit 26e88c6 into master Feb 24, 2021
@karzak karzak deleted the kd-fix-time-elapsed branch February 24, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denalimarsh denalimarsh denalimarsh approved these changes

@rhuairahrighairidh rhuairahrighairidh rhuairahrighairidh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karzak @rhuairahrighairidh @denalimarsh