code warnings/quality

[peltco]

I see a lot of things that would be considered code quality violations in placed where i work. (I agree that at times they might be overy strickt like meaningless naming conventions so no judgements here). Mainly the 300+ compiler warnings, however, is something i would recommend fixing. They range from having exactly the same using statements multiple times, to code (functions or even whole files) that is commented out, to disposables that are never disposed.

Would it be appreciated if i generated some pull requests that fixes these issues? do you guys have coding guidelines? My experience is that if you fix those things you can pay attention to the more meaingfull warnings too and thus helping improve the stability of the game.

[t3hk0d3]

They just don't care. Releasing SE source code was rather PR and help to modders, not meaningful policy.

[Prophesix]

I say we clean it up I wouldn't mind helping out, just give me a standard
and I will use it :)

On Mon, Dec 14, 2015 at 5:46 AM, Igor Yamolov notifications@github.com
wrote:

They just don't care.

—
Reply to this email directly or view it on GitHub
#462 (comment)
.

[KennyTK]

The main issue to cleaning up this code is that the Github is not often updated weekly with the new additions to the game. As far as I know its hardly ever touched by Keen anymore.
(fixed speeling)

[Prophesix]

That would really suck.... I was hoping it was a game I would be able to
contribute to... (The whole reason I started watching it) So the code is
out of date and not the latest being used now?

On Mon, Dec 14, 2015 at 7:48 AM, Kenny notifications@github.com wrote:

The main issue to cleaning up this code is that the Github is not often
updated weekly with the new additions to the game. As far as I know its
hardle ever touched by Keen anymore.

—
Reply to this email directly or view it on GitHub
#462 (comment)
.

[KennyTK]

Most of the files haven't been touched in a month so as far as I know, yes.

[Prophesix]

I wonder how we would get them to update the git so we can contribute stuff
thats useful....

On Mon, Dec 14, 2015 at 8:00 AM, Kenny notifications@github.com wrote:

Most of the files haven't been touched in a month so as far as I know,
yes.

—
Reply to this email directly or view it on GitHub
#462 (comment)
.

[peltco]

@Prophesix my thoughts exactly. Except for great PR and a great game it's also an opportunity for them to grap into a community of developers who would love to help out.

[t3hk0d3]

@peltco there is some reasons why they don't do that besides legal - ethical.

And legal issues is quite big thing too - when you contribute your code to something you become co-author. Some countries laws enforce that to the point that you can't grant your author right to someone else, even if you wish to. That might be an issue for commercial project. One guy might change his mind at some point and start sueing Keen, demanding money, because his PR was pulled at some point, so he became co-author. Thats quite a risk.

Space Engineers ain't Open Source project. Just keep it in mind.

[peltco]

@t3hk0d3 I know several project that require you to sign wavers for that. And i havn't heared about that being challenged in court. (It's what i do for every employer i work for for example so somehow those contracts have to be valid).

[t3hk0d3]

@peltco I've just mentioned generic issues why commercial projects don't like pulling 3rd party code.
Just imagine amount of possible paper work for each PR on github.

[peltco]

that's why i made this post, hopeing someon from Keen would respond.

also from the eula

By making a pull request on our GitHub repository, you're stating that you're author of these changes or have rights to the changes you've made and you're giving us the right to use it in any way.