Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update errorprone to v2.23.0 #266

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 21, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.errorprone:error_prone_test_helpers (source) 2.21.1 -> 2.23.0 age adoption passing confidence
com.google.errorprone:error_prone_core (source) 2.21.1 -> 2.23.0 age adoption passing confidence
com.google.errorprone:error_prone_check_api (source) 2.21.1 -> 2.23.0 age adoption passing confidence

Release Notes

google/error-prone (com.google.errorprone:error_prone_test_helpers)

v2.23.0: Error Prone 2.23.0

New checks:

Bug fixes and improvements: #​3897, #​4114, #​4123

Full Changelog: google/error-prone@v2.22.0...v2.23.0

v2.22.0: Error Prone 2.22.0

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #​3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #​3803.

New checks:

Bug fixes and improvements:

  • Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
  • Prevent SuggestedFixes#renameMethod from modifying return type declaration (#​4043)
  • Fix UnusedVariable false positives for private record parameters (#​2713)
  • When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#​2910)
  • CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#​4009)
  • UnusedVariable: exclude junit5's @RegisterExtension (#​3892)
  • Support running all available patch checks (#​947)
  • Upgrade java-diff-utils 4.0 -> 4.12 (#​4081)
  • Flag unused Refaster template parameters (#​4060)
  • Support @SuppressWarnings("all") (#​4065)
  • Prevent Refaster UMemberSelect from matching method parameters (#​2456)
  • MissingDefault : Don't require // fall out comments on expression switches (#​2709)
  • Skip UnnecessaryLambda findings for usages in enhanced for loops (#​2518)
  • Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#​3797)
  • Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (#​2753)
  • UnusedMethod: Added exempting variable annotations (#​2881)

Full Changelog: google/error-prone@v2.21.1...v2.22.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge (rebase) September 21, 2023 21:59
@renovate renovate bot changed the title fix(deps): update errorprone to v2.22.0 fix(deps): update errorprone to v2.23.0 Oct 18, 2023
@KengoTODA
Copy link
Owner

Errorprone v2.22.0 makes the testRefactoringWithAnnotation test failed, and it comes from the "Support @SuppressWarnings("all") (google/error-prone#4065)" change in this release. To stabilize test cases, I've removed annotations from the test code.

value of:
    maybeFormat(...)
expected:
    …gs("all")
      private Logger logger = LoggerFactory.get…
but was:
    …gs("all")
      private static Logger LOGGER = LoggerFactory.get…
	at app//com.google.errorprone.BugCheckerRefactoringTestHelper$TestMode$1.verifyMatch(BugCheckerRefactoringTestHelper.java:92)
	at app//com.google.errorprone.BugCheckerRefactoringTestHelper.runTestOnPair(BugCheckerRefactoringTestHelper.java:277)
	at app//com.google.errorprone.BugCheckerRefactoringTestHelper.doTest(BugCheckerRefactoringTestHelper.java:257)
	at app//jp.skypencil.errorprone.slf4j.Slf4JLoggerShouldBeNonStaticTest.testRefactoringWithAnnotation(Slf4JLoggerShouldBeNonStaticTest.java:63)

Signed-off-by: Kengo TODA <skypencil@gmail.com>
Copy link
Contributor Author

renovate bot commented Dec 9, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

sonarcloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@renovate renovate bot merged commit 7d0da3d into master Dec 9, 2023
2 checks passed
@renovate renovate bot deleted the renovate/errorprone branch December 9, 2023 09:25
Copy link

github-actions bot commented Dec 9, 2023

🎉 This PR is included in version 0.1.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant