-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamespace #520
Merged
Merged
renamespace #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
force-pushed
the
namespace-shipdk
branch
from
April 26, 2024 05:10
30044d6
to
2664100
Compare
xoascf
pushed a commit
to xoascf/libultraship
that referenced
this pull request
May 6, 2024
* renamespace * clang format * wii u fix * more wii u fixes * actually commit the thing * keep on fixin on * couple more * apparently that header is causing issues * clang format * fix build * ShipDK -> Ship * clang format * json resource in ship namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #499
todo
Ship::
instead ofShipDK::
post-merge todos:
GfxDebugger
(LUS
namespace) included inContext
(ShipDK
namespace) Don't directly includeLUS::GfxDebugger
inShip::Context
#521LoadGuiTexture
onGui
(ShipDK
namespace) takes in aLUS::Texture
Don't requireLUS::Texture
inShip::Gui
#522Gui
abstraction #507 by makingImGuiRenderer
LUS::ImGuiRenderer
and inheriting fromShipDK::GuiRenderer
RegisterGlobalResourceFactories
inShipDK::ResourceLoader
adds a bunch of LUS resources Figure out what we want to do aboutRegisterGlobalResourceFactories
#523