Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Actions" capability #322

Closed

Conversation

ChristopherJennings
Copy link
Contributor

@ChristopherJennings ChristopherJennings commented Aug 31, 2019

Motivation

Fixes #210 and #234

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@ChristopherJennings
Copy link
Contributor Author

Still WIP. The core backend code is updated and returns the one action I've added. Still need to finish the UI and add tests, though I'm not sure what we'd do for testing on this as it's really more requiring integration testing since it's DB changes. We might forgo testing on the actual actions for now at least and maybe just test that the results are correct based on required options that the action needs.

@ChristopherJennings
Copy link
Contributor Author

And unfortunately, due to the deep nature of the refactor for reports/actions/modules this touches more files than I'd like, but they're mostly minimal and just renames of things.

@ChristopherJennings
Copy link
Contributor Author

UI updated and ability to pass options added. Next steps:

  1. Finish implementing Migrate "Reset Global administrator" module to V4 report #234
  2. Figure out testing situation
  3. Peer code review

@petrsvihlik petrsvihlik requested review from JosefDvorak and removed request for kentico-timothyf March 30, 2020 07:56
@kentico-ericd
Copy link
Member

Closing as merged in #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable reports to provide actions to users
2 participants