[BUG]: fix major bugs in PyKE #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barentsen
requested changes
Mar 24, 2017
kepregr.py
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| from pyraf import iraf | |||
| import numpy, sys, time, pyfits, pylab | |||
| from pyfits import * | |||
| from astropy.io import fits as pygfits | |||
There was a problem hiding this comment.
do you mean pyfits instead of pygfits?
barentsen
approved these changes
Mar 24, 2017
|
The last commit addresses the changes on the |
|
Thanks @mirca! All these changes look sensible to me! |
|
@barentsen Are you happy if I merge this as is or would you like to play with it before? x) |
barentsen
reviewed
Apr 25, 2017
keptrial.py
Outdated
| fc='#ffff00',lw=2) | ||
| plt.ion() | ||
| plt.figure(1,figsize=[7,10]) | ||
| plt.clf() |
There was a problem hiding this comment.
The indentation is a bit funny here?
mirca
commented
Apr 25, 2017
kepbls.py
Outdated
| pylab.grid() | ||
| plt.plot(ptime[1:-1],pout[1:-1],color=lcolor,linestyle='-',linewidth=lwidth) | ||
| plt.fill(ptime,pout,color=fcolor,linewidth=0.0,alpha=falpha) | ||
| plt.xlabel(xlab, {'color' : 'k'}) |
|
@barentsen @mrtommyb merging in 3, 2, 1... |
Update .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @barentsen @mrtommyb