Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python code style for keparith module #3

Closed
wants to merge 1 commit into from
Closed

Improve Python code style for keparith module #3

wants to merge 1 commit into from

Conversation

milmazz
Copy link
Contributor

@milmazz milmazz commented Jun 28, 2016

No description provided.

@barentsen
Copy link
Member

@milmazz Many thanks for taking the time to review the code style and submitting a pull request. Unfortunately PyKE does not have unit tests at the moment, which makes it tricky to verify that the style changes do not introduce any accidental changes in the program behavior. I would like to hold off with merging these changes, for now, until we have a way to test. What do you think?

Again, thx++ for taking this effort.

@milmazz
Copy link
Contributor Author

milmazz commented Jul 7, 2016

@barentsen Indeed, without any Unit Tests and without Continuous Integration (e.g. TravisCI), is tricky to verify the project's consistency even if a change is minimal. I hope that this situation, in the long run, does not keep out people from collaborating.

My concern is that if somebody updates the keparith.py this PR surely will enter in a conflict state.

Do you have plans to include any Unit Test suite? what do you think about pytest? I can help with this if you want.

Please, just let me know what do you think.

@barentsen
Copy link
Member

@milmazz At the moment we are not actively developing PyKE due to time constraints. We would certainly like to see an improved version, in particular to enable the PyRAF dependencies to be reduced or removed. Such a new version should definitely come with unit tests. Pytest and Travis would be a great way to go.

@mirca
Copy link
Member

mirca commented Apr 27, 2017

I'm closing this in favor of #5. Thanks @milmazz, anyways!

@mirca mirca closed this Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants