Change the output format to be very similar to a TESS FFI #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barentsen
reviewed
Oct 9, 2018
k2mosaic/mosaic.py
Outdated
|
|
||
| ### Put tstart/stop and date-obs/end in here! How do we pull in time, and where do we store it?? | ||
| if self.time is not None: | ||
| pass # compute the time values |
There was a problem hiding this comment.
This will need to be implemented.
|
This pull request is now ready for review, @barentsen! I sent you a sample .fits file on slack- see if you can find any errors in the headers. |
|
I fixed a small bug... now let's see if Travis coughs.. |
|
Sanity check of the times: Header of Original TPF says: > KeplerTargetPixelFile('ref/ktwo200068780-c91_lpd-targ.fits.gz')[2].astropy_time.iso
array(['2016-04-22 15:17:46.080'], dtype='<U23')Very close, though I don't understand why the latter is not exactly in the middle of DATE-OBS and DATE-END. |
|
The comment above is invalid because I was using a TPF from a different channel. Using a TPF from the same channel yields the expected times! |
|
This looks great! Thanks for working on this @amcody. Merging in 3 ... 2 ... |
barentsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K2mosaic now creates a multi-extension file instead of a single extension image. This should be compatible with TESS FFI format, as well as include the key K2 header keywords. It also allows the user a new option of selecting whether they want background subtracted output images (if available).
To do:
-Figure out why this is so slow!
-Need to pass time keywords to the headers (how?)
-Currently many header keywords are hard coded in. Better to move to a template file?
-Complete image and uncertainty extensions headers
-Decide what to do about WCS, which currently relies on a K2 FFI being stored (AMC doesn't like)
@barentsen when would be a good time to discuss?