Added some additional keywords to mosaic #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barentsen
reviewed
Dec 13, 2018
k2mosaic/mosaic.py
Outdated
| @@ -171,6 +182,12 @@ def _make_primary_hdu(self): | |||
| hdu.header.cards['DATE-OBS'].comment = 'TSTART as UTC calendar date' | |||
| hdu.header['DATE-END'] = self.dateend | |||
| hdu.header.cards['DATE-END'].comment = 'TSTOP as UTC calendar date' | |||
| hdu.header['MJD-BEG'] = self.mjdbeg | |||
| hdu.header.cards['MJD-BEG'].comment = 'TSTART as modified barycentric Julian date' | |||
| hdu.header['MJD-end'] = self.mjdend | |||
There was a problem hiding this comment.
This probably doesn't change the output, but let's use uppercase here:
Suggested change
| hdu.header['MJD-end'] = self.mjdend | |
| hdu.header['MJD-END'] = self.mjdend |
barentsen
reviewed
Dec 13, 2018
k2mosaic/mosaic.py
Outdated
| @@ -183,6 +200,8 @@ def _make_primary_hdu(self): | |||
| hdu.header.cards['TELESCOP'].comment = 'telescope' | |||
| hdu.header['INSTRUME'] = 'Kepler Photometer' | |||
| hdu.header.cards['INSTRUME'].comment = 'detector type' | |||
| hdu.header['FILTER'] = 'Kepler' | |||
| hdu.header.cards['FILTER'].comment = 'filter' | |||
There was a problem hiding this comment.
I guess we can be a bit more informative in this comment, I suggest:
Suggested change
| hdu.header.cards['FILTER'].comment = 'filter' | |
| hdu.header.cards['FILTER'].comment = 'photometric passband' |
barentsen
reviewed
Dec 13, 2018
k2mosaic/mosaic.py
Outdated
| hdu.header['EXPOSURE'] = int_time/3600./24. * num_frm | ||
| hdu.header.cards['EXPOSURE'].comment = '[d] time on source' | ||
|
|
||
| hdu.header['LIVETIME'] = frametim/3600./24. * num_frm * deadc |
There was a problem hiding this comment.
This probably doesn't change anything, but it's slightly better to not repeat the computation, i.e.:
Suggested change
| hdu.header['LIVETIME'] = frametim/3600./24. * num_frm * deadc | |
| hdu.header['LIVETIME'] = hdu.header['TELAPSE'] * deadc |
|
@amcody This all looks good! I nit-picked a few small things, but this will be good to merge! |
|
Should be fixed now, @barentsen! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds keywords requested by MAST, such as FILTER='Kepler', MJD-BEG and END, and XPOSURE.