Fix test for process_metrics to allow overwriting existing results

KernelTuner · Apr 19, 2023 · f052353 · f052353
1 parent c5f36de
commit f052353
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/kernel_tuner/runners/sequential.py b/kernel_tuner/runners/sequential.py
@@ -99,7 +99,7 @@ def run(self, parameter_space, tuning_options):
                     logging.debug('kernel configuration was skipped silently due to compile or runtime failure')
 
             # only compute metrics on configs that have not errored
-            if not isinstance(params.get(tuning_options.objective), ErrorConfig):
+            if tuning_options.metrics and not isinstance(params.get(tuning_options.objective), ErrorConfig):
                 params = process_metrics(params, tuning_options.metrics)
 
             # get the framework time by estimating based on other times

diff --git a/test/test_util_functions.py b/test/test_util_functions.py
@@ -667,15 +667,15 @@ def test_process_metrics():
     with pytest.raises(ValueError):
         params = process_metrics(params, {})
 
-    # test ValueError is raised when b already exists in params
+    # test if a metric overrides any existing metrics
     params = {
         "x": 15,
         "b": 12
     }
     metrics = OrderedDict()
     metrics["b"] = "x"
-    with pytest.raises(ValueError):
-        params = process_metrics(params, metrics)
+    params = process_metrics(params, metrics)
+    assert params["b"] == 15
 
 
 def test_parse_restrictions():