Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP Backend #199

Merged
merged 66 commits into from
Sep 8, 2023
Merged

HIP Backend #199

merged 66 commits into from
Sep 8, 2023

Conversation

MiloLurati
Copy link
Contributor

@MiloLurati MiloLurati commented Apr 24, 2023 •
edited
Loading

This pull request introduces a new HIP backend for Kernel Tuner.

Milo Lurati and others added 30 commits April 3, 2023 18:18
added files and started implementation of examples/hip/test_vector_ad…
8b54914 
…d.py examples/hip/vector_add.py and backend/hip.py
added if statement for HIP lang detection in core.py class DeviceInte…
59a979f 
…rface
added hip related code to detect_language in util.py
303e4d5
modified hip tests to enclude hIP lang argument speficication when ca…
c327893 
…lling tune_kernel
added (not tested) compile function to backend/hip.py
0f66875
added (not tested) start_event and stop_event functions to backend/hi…
3970087 
…p.py
added (not tested) kernel_finished function to backend/hip.py
f92471c
changed how pyhip is imported (via import sys with specific path of s…
3425e2d 
…ystem)
added (not tested) to HIPFunctions arguments env, max_threads, name
ef476e1
self.name of HIPFunctions works
e120aca
import of pyhip based on PYHIP_PATH
5cdf495
added test/test_hip_functions.py with test_ready_argument_list (not s…
d150602 
…ure of its correctness) and test_compile
added hip related code for tests
44b846f
kernel_tuner/backends/hip.py::compile passes test/test_hip_functions.…
9f691d0 
…py::test_compile
ready_argument_list passes partialy due to diffiulty with comparing c…
52ececf 
…types in test (not sure whats wrong yet)
added (not tested) run_kernel, memset, memcpy_dtoh, memcpy_htod
d3ae6ba
not able to solve hipGetDeviceProperties issue, for now pached manually
cbe9997
added (not tested) observer code
13d93bd
added (not tested) observer code
d9512ac
update
578dd30
debug updates
dc0b350
added mem calls to ready_argument_list
9732bf7
updates
2b3dda6
corrected synchronize in backend/hip.py
5a89c85
clean up
fc183d8
resolved memory error caused by ready_argument_list
063dd15
examples/hip/vector_add.py runs successfully on AMD
48db638
examples/hip/vector_add.py runs successfully on AMD
e003d1c
@MiloLurati
modified (not tested) memset, copy_constant_memory_args
f6cc000
@MiloLurati
modified (not tested) memset, copy_constant_memory_args
2505db9
MiloLurati and others added 19 commits May 2, 2023 12:29
@MiloLurati
Merge pull request #1 from MiloLurati/PyHIPCov
ce4dc1e 
PyHIP Coverage
@MiloLurati
Merge branch 'KernelTuner:master' into HIPbackend
c7e238e
@MiloLurati
quick install HIP
0ab790d
@MiloLurati
Installing HIP doc updated
fe7bad1
@MiloLurati
HIP update INSTALL.rst
47b07ee
@MiloLurati
HIP update INSTALL.rst
6862f14
@MiloLurati
HIP update interface.py doc
eab0306
@MiloLurati
added updated architecture diagram PNG
cab70bc
@MiloLurati
HIP update design.rst
1f7d256
@MiloLurati
HIP update core.py DeviceInterface doc
d71b11b
@MiloLurati
HIP update design.rst
ee0c4d5
@MiloLurati
HIP update README.rst
1220cf5
@MiloLurati
Merge branch 'KernelTuner:master' into HIPbackend
7498543
@MiloLurati
updates for running benchmarks with HIP on AMD
f8b58a1
@MiloLurati
update to test_compile
6c44bda
@MiloLurati
handeling loop unroll for HIP
c8b9198
@MiloLurati
added vector add in simulation mode to examples
3f89fc3
@MiloLurati
updates hip vector add examples
ee8140b
@MiloLurati
Merge branch 'KernelTuner:master' into HIPbackend
598ca39
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@benvanwerkhoven
Copy link
Collaborator

Thanks @MiloLurati for all your hard work on the HIP backend!

@benvanwerkhoven benvanwerkhoven merged commit 4f0aa8f into KernelTuner:master Sep 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiloLurati @benvanwerkhoven