Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchspace improvements and project meta modernization #214

Merged
merged 73 commits into from
Oct 3, 2023
Merged

Searchspace improvements and project meta modernization #214

merged 73 commits into from
Oct 3, 2023

Conversation

fjwillemsen
Copy link
Collaborator

Several major changes in this pull request:

  • Major speedup due to new parser and using revamped python-constraint for searchspace building
  • Implemented ability to use PySMT and ATF for searchspace building
  • Added Poetry for dependency and build management
  • Switched from setup.py and setup.cfg to pyproject.toml for centralized metadata, added relevant tests
  • Updated GitHub Action workflows to use Poetry
  • Updated dependencies, most notably NumPy is no longer version-locked as scikit-opt is no longer a dependency
  • Set up Nox for testing on all supported Python versions in isolated environments
  • Added linting information, VS Code settings and recommendations
  • Dropped Python 3.7 support

@fjwillemsen
Implemented PySMT in Kernel Tuner
9cf0067
@fjwillemsen
Added mapping of parameter names to integers for better perfomance
fc3bef6
@fjwillemsen
Improved tests and compatibility for parameter mapping
f72e66b
@fjwillemsen
Switch from setup.py/cfg to pyproject.toml
1e762f8
@fjwillemsen
Added linting information, VS Code settings and recommendations
552c445
@fjwillemsen
Always return compiled functions as a list, application of formatter
ef83737
@fjwillemsen
Improvements to string to restriction parsing
18d3a55
@fjwillemsen
Major speedup due to restriction splitting with parameter usage detec…
b684373 
…tion
@fjwillemsen
Refactored tests for parsing restrictions due to changes
d9fcf76
@fjwillemsen
Minor improvements to an assert and a testcase
b28ca74
@fjwillemsen
Searchspace list to NumPy conversion only happens if needed
0f3ea46
@fjwillemsen
Searchspace objects can now be initialized from ATF logfiles (caches)…
cd3592e 
…, unified searchspace builder returns
@fjwillemsen
Added safeguard to prevent changing ATF block size names after compil…
8c65d22 
…ation stage
@fjwillemsen
Fixed Constraint conversions
31f465b
@fjwillemsen
Changed to non-forwardchecking by default, moved MaxProdConstraint to…
930ac2f 
… constraint
@fjwillemsen
Parsing of common operations to python-constraint built-in Constraints
41785d6
@fjwillemsen
Fixed an issue with converting restrictions to Constraints
49d73c0
@fjwillemsen
Enabled converting to Constraint with '>' and '<' as well, added use …
704d125 
…of MinProdConstraint
@fjwillemsen
Added mapping of '>' to '>=' and '<' to '<=' for single-variable rest…
7b436f2 
…riction
@fjwillemsen
Return None on trying to convert to numeric Constraint
c8da4ea
@fjwillemsen
Automatic transformation of restrictions with multiple comparators to…
2d8df29 
… multiple restrictions with a single comparator, increasing the chance of converting to a built-in restriction
@fjwillemsen
Added support for PySMT on generated searchspaces
4b504e6
@fjwillemsen
Several improvements and fixes for PySMT builder, especially for pres…
36c013f 
…erving order
@fjwillemsen
Fixed an issue where restrictions would not be parsed to specific con…
8a5df97 
…straints, added tests for conversion to constraints, added requirement for Python version
@fjwillemsen
Removed redundant parameter mapping
a576dba
@fjwillemsen
Minor fixes for testing
9b44979
@fjwillemsen
Made scikit-opt (skopt) optional in strategy bayes_opt
4a26ff3
@fjwillemsen
Changed to Poetry and pyproject.toml
a8a13b5
@fjwillemsen
Added tests for pyproject.toml
7436ffc
@fjwillemsen
Updated changelog to reflect changes, updated VS Code settings
b399bcc
This was referenced Sep 19, 2023
Closed
Closed
@fjwillemsen
Improved Nox with optional dependencies for CUDA, HIP, OpenCL and arg…
d9a8d9f 
…uments to disable these
@fjwillemsen
Updated Contributing and Installation guidelines, specifically added …
4fe7f01 
…development environment setup instructions, also added code syntax highlighting for Sphinx
@fjwillemsen
Minor changes to dependencies and environment setup
47c069c
@fjwillemsen
Minor changes to dependencies and environment setup
862cc75
@fjwillemsen
Added bruteforce solver to Searchspace object, improved tests for Sea…
b7aa244 
…rchspace
@fjwillemsen
Solved a bug in the constraints parsing that caused wrong searchspace…
8dbb817 
… outcomes, added and expanded searchspace tests, resolved warnings
@fjwillemsen
Added missing nox-poetry to test dependencies
b08950a
@fjwillemsen
Added nox-poetry to GitHub test Action
2e8edad
@fjwillemsen
Added Poetry setup to Github Test Action
e4b6083
@fjwillemsen
Added extensive development environment setup instructions, updated i…
25c5452 
…nstallation documentation
@fjwillemsen
Add an exception for the nvml_ parameter check if in simulation mode
a39d5ae
@fjwillemsen
Added optional additional (non-dependency) installation to Noxfile, w…
7843147 
…ith CUDA version differentiation. Added a tolerance to the energy power frequency model test.
@fjwillemsen
Fixed additional test input argument
c777914
@fjwillemsen
Improved detection of CUDA version using NVCC
fee5220
@fjwillemsen
Improved automatic selection of cupy prebuilt version, from most exac…
468d254 
…t to most general, and improved warnings
@fjwillemsen
Set the default environment used by Nox using a file
4ffc1c4
@fjwillemsen
Updated the documentation for the Noxenv file and other minor improve…
d177260 
…ments
@fjwillemsen fjwillemsen mentioned this pull request Oct 2, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 47 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fjwillemsen fjwillemsen merged commit ff38736 into master Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvanwerkhoven benvanwerkhoven Awaiting requested review from benvanwerkhoven

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fjwillemsen