Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to TS and improvements #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Migration to TS and improvements #11

wants to merge 6 commits into from

Conversation

dsolimando
Copy link

  • TS migration
  • allow to use template string to customise counter display
  • allow conditional styling by passing function as style prop

Damien Solimando added 6 commits January 24, 2019 15:18
WIP
5a19aa3
add babel config file
cbc6566
js -> ts
3501da9
use local Counter module and remove npm dependency
d3133ab
Counter improvements
1727d6a 
* migrate to TS
* allow to use template string to customise counter display
* allow to condition styling by passing function
change template signature
da38942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdivani mdivani mdivani approved these changes

@swushi swushi swushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsolimando @mdivani @swushi