Skip to content

Commit

Permalink
Merge pull request #9 from KevinAst/initial
Browse files Browse the repository at this point in the history
publish: v0.1.1 react-native android patch
  • Loading branch information
KevinAst authored Mar 7, 2018
2 parents 2d2d2c9 + 0f4f4d4 commit ecf20bd
Show file tree
Hide file tree
Showing 3 changed files with 87 additions and 6 deletions.
81 changes: 77 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,81 @@
# Change Log

The **feature-redux**project adheres to [Semantic
The **feature-redux** project adheres to [Semantic
Versioning](http://semver.org/).

Each release, along with migration instructions, is documented on the
[Github Releases](https://github.com/KevinAst/feature-redux/releases)
page.
Each release is documented on this page *(in addition to the [Github
Release Notes](https://github.com/KevinAst/feature-redux/releases))*,
and **contains migration instructions**.

## Summary:

Release | What | *When*
---------|-------------------------------------------------|------------------
[v0.1.1] | react-native android patch | *March 7, 2018*
[v0.1.0] | Initial Release | *March 6, 2018*

[v0.1.1]: #v011---react-native-android-patch-march-7-2018
[v0.1.0]: #v010---initial-release-march-6-2018



<!-- UNRELEASED **************************************************************************
TEMPLATE:
## vn.n.n - DESC *(DATE ?, 2018)*
[GitHub Content](https://github.com/KevinAst/feature-redux/tree/vn.n.n)
&bull;
[GitHub Release](https://github.com/KevinAst/feature-redux/releases/tag/vn.n.n)
RUNNING CONTENT (pop out as needed) ...
UNRELEASED ******************************************************************************** -->





<!-- *** RELEASE *************************************************************** -->

## v0.1.1 - react-native android patch *(March 7, 2018)*

[GitHub Content](https://github.com/KevinAst/feature-redux/tree/v0.1.1)
&bull;
[GitHub Release](https://github.com/KevinAst/feature-redux/releases/tag/v0.1.1)

**NOTE**: This release is a **non-breaking change** _(i.e. no API was affected)_.

- A patch was applied in support of **react-native android**.

When running react-native under android, receiving the following
exception:

```
ERROR: undefined is not a function
evaluating 'content[typeof Symbol === 'function' ? Symbol.iterator: '@@iterator']()'
```

This is a transpiler issue related to the es6 "for of" loop. It is
believed to be limited to the **react-native android JS engine**.

This may be a babel transpiler issue (possibly due to a stale babel
version), or an issue with with react-native android's JS engine.
The problem was temporarily avoided by employing old style es5 "for
loop" constructs (till further research is conducted).







<!-- *** RELEASE *************************************************************** -->

## v0.1.0 - Initial Release *(March 6, 2018)*
[GitHub Content](https://github.com/KevinAst/feature-redux/tree/v0.1.0)
&bull;
[GitHub Release](https://github.com/KevinAst/feature-redux/releases/tag/v0.1.0)

**This is where it all began ...**

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "feature-redux",
"version": "0.1.0",
"version": "0.1.1",
"description": "feature-u redux integration",
"main": "lib/index.js",
"browser": {
Expand Down
10 changes: 9 additions & 1 deletion src/reducerAspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,15 @@ export function accumAppReducer(aspectName, activeFeatures, allowNoReducers$=nul
// }
// }
const shapedGenesis = {};
for (const feature of activeFeatures) {

// using old style es5 "for loop" in lieu of es6 "for of"
// ... issue in react-native android JS engine:
// ERROR: missing Symbol.iterator: '@@iterator'
// ... may be related to android JS engine -or- stale babel transpiler
// ... for now, using es5 "for loop" is path of least resistance
//for (const feature of activeFeatures) {
for (let i=0; i<activeFeatures.length; i++) {
const feature = activeFeatures[i];

// only interpret features that define our aspect
if (feature[aspectName]) {
Expand Down

0 comments on commit ecf20bd

Please sign in to comment.