Add logic to only show group members on free-for-all factions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul2kandrews
changed the title
Kexanone
requested changes
Aug 5, 2024
addons/PlayerMapMarkers/scripts/Game/FPM/Groups/SCR_GroupsManagerComponent.c
Outdated
Show resolved
Hide resolved
addons/PlayerMapMarkers/scripts/Game/FPM/Groups/SCR_GroupsManagerComponent.c
Outdated
Show resolved
Hide resolved
| // Cast to FPM so we can get the player this marker is associated with | ||
| FPM_MapMarkerPlayer fpmMarker = FPM_MapMarkerPlayer.Cast(dynamicMarker); | ||
| if (!fpmMarker) | ||
| continue; |
There was a problem hiding this comment.
This is no good. You basically break any other type of dynamic markers that way.
There was a problem hiding this comment.
Addressed in fb90c8a
Kexanone
force-pushed
the
Show-Group-Members-On-FFA-Factions
branch
from
7fcb608
to
f5f04c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch allows Player Map Markers to render the positions of group members to each other on a faction that is not friendly to itself. It also forces the position of the local player to always be shown.
Closes issue #7