-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typings/docs: All typings and documentation fixes #42
Conversation
Thanks a lot for the PR, I also appreciate the various jsdoc changes, typos and improvement. |
Just wondering why it doesn't run CI on the PR though |
You know I completely forgot this wasn't Gitlab, I don't think there's another way of marking WIP/draft without closing and reopening |
yeah i actually thought you could change it to draft after it was already created but guess it's not possible :') |
CI: also run test on PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things really especially considering the PR size.
Some of my comments needs to be taken care of with particular attention though.
I mostly noticed some inconsistency in Library, and I didn't comment everything there.
Lot of missing @memberof statement, sometimes there are return type, sometimes there are not?
Last thing, regenerate a lockfile if you want, but we need the lockfile to be commited
Thanks a lot for this PR. I already said that but I am really really thankful for your work and the time you invested in this. We will continue the work of this PR in a second PR to split index.d.ts in separate files as we discussed. |
Adds proper JSDoc/TypeScript typings up to date as of PR