Fix: Ensure consistent logo display across Bani Overlay layouts #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gauravjeetsingh
requested changes
Apr 17, 2024
|
@yadvirkaur The logo is still old one in other layouts Can we use the white transparent logo in every layout, and in top and bottom layouts, adding a shadow to the image, so that it stays visible. I am thinking of making it something like this |
Gauravjeetsingh
requested changes
Jul 17, 2024
|
Yes, will update this. Previously I kept the transparent logo only where it was inside the box. |
Gauravjeetsingh
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1909