revision for lesson 2 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaesguerra
approved these changes
Jul 3, 2024
| the long term I think we should evaluate possible replaces for <code>redux</code> that don't | ||
| have this preformance issue like <code>jotai</code>, <code>zustand</code>, or <code>recoil.js</code>. | ||
| - <code>React.useMemo(callback)</code> and <code>React.memo(Component, arePropsEqual?)</code> are | ||
| both use to memoize things. The former is used for memoizing computations _within_ a functional |
There was a problem hiding this comment.
Suggested change
| both use to memoize things. The former is used for memoizing computations _within_ a functional | |
| both used to memoize things. The former is used for memoizing computations _within_ a functional |
| emitter?.on("bar", setBar); | ||
|
|
||
| return <h1>bar = {bar}</h1>; | ||
| }, arePropsEqual); | ||
| ``` | ||
|
|
||
| ## Notes |
There was a problem hiding this comment.
Thanks for answering my questions! 😄
| @@ -4,6 +4,17 @@ export default function Exercise2() { | |||
| return ( | |||
| <div> | |||
| <h1>Exercise 2: Prevent Context From Rendering</h1> | |||
| <p> | |||
There was a problem hiding this comment.
Thanks for adding this, very helpful!
kevinb-khan
force-pushed
the
default-exports
branch
from
4b75d07 to
b884028
Compare
kevinb-khan
force-pushed
the
revise-lesson-2
branch
from
f19f370 to
b0d1cbd
Compare
kevinb-khan
force-pushed
the
revise-lesson-2
branch
from
b0d1cbd to
e5a43dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses the feedback for lesson 2. It also adds a warning banner to all exercises letting people know that HMR may not work and that they should reload after making changes to the exercises.
Issue: None
Test plan: