Measurer and DeprecatedStandin to use noopValidator (#1651)

## Summary:
Just made sense to share this logic

Issue: LEMS-2371

## Test plan:
No logic should change

Author: handeyeco

Reviewers: Myranae, jeremywiebe

Required Reviewers:

Approved By: Myranae

Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, 🚫 Publish npm snapshot (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, 🚫 Publish npm snapshot (ubuntu-latest, 20.x), 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald

Pull Request URL: #1651

.changeset/hip-cameras-mix.md

@@ -0,0 +1,5 @@
+---
+"@khanacademy/perseus": patch
+---
+
+Consolidate Measurer and DeprecatedStandin to use noopValidator

packages/perseus/src/widgets/__shared__/noop-validator.test.tsx

@@ -2,6 +2,26 @@ import noopValidator from "./noop-validator";
 
 describe("noop-validator", () => {
     it("returns a pointless object", () => {
-        expect(noopValidator()).toHaveBeenAnsweredCorrectly();
+        const result = noopValidator();
+        expect(result).toHaveBeenAnsweredCorrectly();
+
+        // This is is just to narrow the type
+        // the expect above checks correctness
+        if (result.type === "points") {
+            expect(result.earned).toBe(0);
+            expect(result.total).toBe(0);
+        }
+    });
+
+    it("can be configured to be pointful", () => {
+        const result = noopValidator(1);
+        expect(result).toHaveBeenAnsweredCorrectly();
+
+        // This is is just to narrow the type
+        // the expect above checks correctness
+        if (result.type === "points") {
+            expect(result.earned).toBe(1);
+            expect(result.total).toBe(1);
+        }
     });
 });

packages/perseus/src/widgets/__shared__/noop-validator.tsx

@@ -8,11 +8,11 @@ import type {PerseusScore} from "../../types";
  * validation logic and the thing validating an exercise
  * should just know to skip these
  */
-function noopValidator(): PerseusScore {
+function noopValidator(points: number = 0): PerseusScore {
     return {
         type: "points",
-        earned: 0,
-        total: 0,
+        earned: points,
+        total: points,
         message: null,
     };
 }

packages/perseus/src/widgets/deprecated-standin/index.tsx

@@ -2,6 +2,7 @@ import Banner from "@khanacademy/wonder-blocks-banner";
 import React from "react";
 
 import {PerseusI18nContext} from "../../components/i18n-context";
+import noopValidator from "../__shared__/noop-validator";
 
 import type {PerseusScore, WidgetExports} from "../../types";
 
@@ -18,20 +19,15 @@ class DeprecatedStandin extends React.Component<Props> {
     static validate(userInput: UserInput, rubric: Rubric): PerseusScore {
         // Since this mean to replace an existing widget the learner
         // WILL earn points for this widget
-        return {
-            type: "points",
-            earned: 1,
-            total: 1,
-            message: null,
-        };
+        return noopValidator(1);
     }
 
     getUserInput: () => UserInput = () => {
         return {};
     };
 
     simpleValidate: (arg1: Rubric) => PerseusScore = (rubric) => {
-        return DeprecatedStandin.validate(this.getUserInput(), rubric);
+        return noopValidator(1);
     };
 
     render() {

packages/perseus/src/widgets/measurer/measurer.tsx

@@ -9,8 +9,7 @@ import _ from "underscore";
 import SvgImage from "../../components/svg-image";
 import {ApiOptions} from "../../perseus-api";
 import GraphUtils from "../../util/graph-utils";
-
-import measurerValidator from "./measurer-validator";
+import noopValidator from "../__shared__/noop-validator";
 
 import type {Coord} from "../../interactive2/types";
 import type {WidgetExports} from "../../types";
@@ -148,7 +147,7 @@ const Measurer: any = createReactClass({
     },
 
     simpleValidate: function () {
-        return measurerValidator();
+        return noopValidator(1);
     },
 
     focus: $.noop,
@@ -186,7 +185,7 @@ const Measurer: any = createReactClass({
 });
 
 _.extend(Measurer, {
-    validate: measurerValidator,
+    validate: noopValidator(1),
 });
 
 const propUpgrades = {