-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browserslist and caniuse-lite packages weekly #1413
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +856 B (+0.1%) Total Size: 854 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
+ Coverage 69.71% 70.95% +1.23%
==========================================
Files 505 508 +3
Lines 105131 105681 +550
Branches 7590 10820 +3230
==========================================
+ Hits 73293 74982 +1689
+ Misses 31662 30699 -963
+ Partials 176 0 -176 see 182 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6ec698d) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1413 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1413 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I have some suggestions inline.
Do we need to do anything with Changesets to make sure the changesets action is happy with this generated PR?
Summary:
This PR introduces a new Github Action that will run weekly (on Monday's at 7:30 am UTC - which maps to somewhere in the night in North America).
We will still need to manually approve and land these PRs to merge the changes (#security). Also, if we do not land the PR before this action runs again, the PR will simply be updated.
Issue: "none"
Test plan:
We can run this action manually to test. Upon running it, a new PR with the title 'chore: update browserslist' should appear.