Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browserslist and caniuse-lite packages weekly #1413

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

This PR introduces a new Github Action that will run weekly (on Monday's at 7:30 am UTC - which maps to somewhere in the night in North America).

We will still need to manually approve and land these PRs to merge the changes (#security). Also, if we do not land the PR before this action runs again, the PR will simply be updated.

Issue: "none"

Test plan:

We can run this action manually to test. Upon running it, a new PR with the title 'chore: update browserslist' should appear.

@jeremywiebe jeremywiebe self-assigned this Jul 15, 2024
@jeremywiebe jeremywiebe marked this pull request as ready for review July 15, 2024 17:29
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .github/workflows/maintenance.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

Size Change: +856 B (+0.1%)

Total Size: 854 kB

Filename Size Change
packages/kas/dist/es/index.js 38.2 kB +1 B (0%)
packages/kmath/dist/es/index.js 4.27 kB +1 B (+0.02%)
packages/perseus-editor/dist/es/index.js 273 kB +798 B (+0.29%)
packages/perseus/dist/es/index.js 414 kB +58 B (+0.01%)
packages/pure-markdown/dist/es/index.js 3.67 kB -2 B (-0.05%)
ℹ️ View Unchanged
Filename Size
packages/math-input/dist/es/index.js 80.8 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 21.6 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.95%. Comparing base (147ab04) to head (6ec698d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
+ Coverage   69.71%   70.95%   +1.23%     
==========================================
  Files         505      508       +3     
  Lines      105131   105681     +550     
  Branches     7590    10820    +3230     
==========================================
+ Hits        73293    74982    +1689     
+ Misses      31662    30699     -963     
+ Partials      176        0     -176     

Impacted file tree graph

see 182 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147ab04...6ec698d. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jul 15, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (6ec698d) and published it to npm. You
can install it using the tag PR1413.

Example:

yarn add @khanacademy/perseus@PR1413

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1413

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. LGTM!

.github/workflows/maintenance.yml Outdated Show resolved Hide resolved
Copy link
Member

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I have some suggestions inline.

Do we need to do anything with Changesets to make sure the changesets action is happy with this generated PR?

.github/workflows/maintenance.yml Outdated Show resolved Hide resolved
.github/workflows/maintenance.yml Outdated Show resolved Hide resolved
.github/workflows/maintenance.yml Outdated Show resolved Hide resolved
@jeremywiebe jeremywiebe merged commit 738bb0c into main Jul 18, 2024
11 checks passed
@jeremywiebe jeremywiebe deleted the jer/browserslist-update branch July 18, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants