Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seemingly useless rubrics #1759

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Oct 16, 2024

Summary:

These rubrics weren't really useful, so I delete them.

Cleanup for: LEMS-2396

Test plan:

Nothing should change, just some type tweaks

@handeyeco handeyeco self-assigned this Oct 16, 2024
@khan-actions-bot khan-actions-bot requested a review from a team October 16, 2024 21:12
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to packages/perseus/src/types.ts, packages/perseus/src/validation.types.ts, packages/perseus/src/widgets/__shared__/noop-validator.ts, packages/perseus/src/widgets/definition/definition.tsx, packages/perseus/src/widgets/explanation/explanation.tsx, packages/perseus/src/widgets/image/image.tsx, packages/perseus/src/widgets/interaction/interaction.tsx, packages/perseus/src/widgets/passage/passage.tsx, packages/perseus/src/widgets/passage-ref/passage-ref.tsx, packages/perseus/src/widgets/video/video.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@handeyeco handeyeco changed the title remove seemingly useless rubrics Remove seemingly useless rubrics Oct 16, 2024
Copy link
Contributor

Size Change: 0 B

Total Size: 866 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 280 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 419 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (95754c2) and published it to npm. You
can install it using the tag PR1759.

Example:

yarn add @khanacademy/perseus@PR1759

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1759

Copy link
Contributor

@Myranae Myranae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! So fast! Thanks for taking care of this!

Did we think we would need the Rubric types for anything scoring related down the road? In other words, will each widget need a Rubric when our new scoring is set up? Maybe we don't know the answer to this yet, and I suppose we can always add these back after we get a better picture of how the widgets are set up. Wait, I think the point is that these won't need to be scored, so, carry on!

Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants