-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove seemingly useless rubrics #1759
base: main
Are you sure you want to change the base?
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (95754c2) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1759 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1759 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! So fast! Thanks for taking care of this!
Did we think we would need the Rubric types for anything scoring related down the road? In other words, will each widget need a Rubric when our new scoring is set up? Maybe we don't know the answer to this yet, and I suppose we can always add these back after we get a better picture of how the widgets are set up. Wait, I think the point is that these won't need to be scored, so, carry on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Summary:
These rubrics weren't really useful, so I delete them.
Cleanup for: LEMS-2396
Test plan:
Nothing should change, just some type tweaks