Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Matrix's Rubric and UserInput types #1760

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Myranae
Copy link
Contributor

@Myranae Myranae commented Oct 17, 2024

Summary:

As part of the Server Side Scoring project, this refactors Matrix's Rubric type to contain only what is necessary for scoring. It also updates its UserInput type to reference Rubric, since both contain the same type of data. Finally, Matrix's validator tests are updated to reflect the new Rubric type.

Issue: LEMS-2469

Test plan:

  • Confirm all checks pass
  • Confirm Matrix still works as expected in Storybook

@Myranae Myranae self-assigned this Oct 17, 2024
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (3d881b2) and published it to npm. You
can install it using the tag PR1760.

Example:

yarn add @khanacademy/perseus@PR1760

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1760

Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 867 kB

Filename Size Change
packages/perseus/dist/es/index.js 420 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 280 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@Myranae Myranae marked this pull request as ready for review October 17, 2024 17:28
@khan-actions-bot khan-actions-bot requested a review from a team October 17, 2024 17:28
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/twelve-beans-raise.md, packages/perseus/src/validation.types.ts, packages/perseus/src/widgets/matrix/matrix-validator.test.ts, packages/perseus/src/widgets/matrix/matrix-validator.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants