Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knip 8: remove unused exports #1778

Open
wants to merge 2 commits into
base: add-knip
Choose a base branch
from
Open

Knip 8: remove unused exports #1778

wants to merge 2 commits into from

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Oct 21, 2024

Summary:

Knip identified these as both unused internally and not exported through our main export files, but please double check!

As far as I can tell, a lot of this was copy/pasted from Webapp where there are duplicate declarations there.

@handeyeco handeyeco self-assigned this Oct 21, 2024
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Oct 21, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/rotten-turkeys-pump.md, testing/wait.ts, packages/perseus/src/sigfigs.ts, packages/perseus/src/multi-items/prop-type-builders.ts, packages/perseus-linter/src/rules/lint-utils.ts, packages/math-input/src/components/aphrodite-css-transition-group/util.ts, packages/math-input/src/components/tabbar/item.tsx, packages/perseus/src/widgets/numeric-input/numeric-input.testdata.ts, packages/perseus/src/widgets/interactive-graphs/graphs/use-transform.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team October 21, 2024 17:05
@handeyeco handeyeco changed the title remove unused exports Knip 8: remove unused exports Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ab79ced) and published it to npm. You
can install it using the tag PR1778.

Example:

yarn add @khanacademy/perseus@PR1778

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1778

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Size Change: +349 B (+0.04%)

Total Size: 867 kB

Filename Size Change
packages/perseus/dist/es/index.js 420 kB +349 B (+0.08%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 281 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants