Create a function to get the public options for LabelImage #2171
Conversation
…ic options for the LabelImage widget
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (3f9f0b7) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2171If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2171 |
|
Size Change: +108 B (+0.01%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
| hideChoicesFromInstructions: boolean; | ||
| multipleAnswers: boolean; | ||
| static: boolean; |
There was a problem hiding this comment.
Curious why these ones are listed as boolean while the others reference the original widget options. Wouldn't it be good to reference the original type for all of the fields that are unchanged?
| const {answers: _, ...publicData} = marker; | ||
| return publicData; |
There was a problem hiding this comment.
So here, instead of building out the wanted object, you're using destructuring to pull out answers, is that correct? What does using the underscore do? Is that just to help signify that we aren't interested in the answers here? Looks like it's needed to satisfy ESLint.
There was a problem hiding this comment.
What does using the underscore do? Is that just to help signify that we aren't interested in the answers here?
Correct!
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@khanacademy/perseus-core": minor | |||
There was a problem hiding this comment.
Should there be a line here for perseus since there are changes there as well?
There was a problem hiding this comment.
Good catch! I guess this is one reason not to generate the changeset until the PR is reviewed 🤔
Issue: LEMS-2769
Test plan:
yarn test