-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Zoomable content within a collapsed parent not showing when expanded (Mobile only) #2185
Merged
mark-fitzgerald
merged 11 commits into
main
from
bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile
Feb 6, 2025
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
76e3ef2
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] docs(ch…
mark-fitzgerald db74887
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Check f…
mark-fitzgerald b146c41
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Add deb…
mark-fitzgerald ca3423b
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] linting
mark-fitzgerald 9181cff
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Merge b…
mark-fitzgerald 8277b59
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Adjust …
mark-fitzgerald 772b99e
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Prettier
mark-fitzgerald 022b05e
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Remove …
mark-fitzgerald ec925c8
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Remove …
mark-fitzgerald cefeed6
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Add a c…
mark-fitzgerald a3859d0
[bugfix/LEMS-2805-blockquote-hidden-in-explanation-on-mobile] Merge b…
mark-fitzgerald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@khanacademy/perseus": patch | ||
--- | ||
|
||
[Bugfix] Zoomable content within a collapsed parent not showing when expanded (Mobile only) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to access
parentElement
here before calling.closest()
? If we don't need to, thenclosest()
would return and would alleviate us from having to use the bullish coalescing operator on the end also.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closest()
also checks the element on which it is called. So, when we find an ancestor with.perseus-renderer
, if we need to do another call forclosest()
, we would end up with the same element, resulting in an infinite loop (speaking from personal experience, unfortunately). Referencing the parent element ensures that we continue traversing up the DOM tree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch! Can you note that in a comment? That was the first thing I wondered and would probably think, "I'll just simplify this code some by refactoring this... " 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!