Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly position autowrapped text lines. Fixes Khan/live-editor#630 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mchenryc
Copy link

This splits out code which renders multiple lines from text$4(...) for reuse in text$6(...), greatly simplifying, and fixing a positioning bug in the latter (Khan/live-editor#630).

Both text$4 and text$6 are still responsible for determining where lines are broken (on newlines, and automatically based on bounds, respectively).

Below are before and after renderings of applying the Processing code, demonstrating the problem and solution in action.

This PR does not, however, include automated tests - in order to execute tests on this fork of Processing on Windows, one must install VisualStudio to build Spidermonkey, prep python, make, etc...), a path I started down, but soon decided against - Processing-js has already made this easy on the upstream fork.

I'm more interested in putting effort toward (Khan/live-editor#596) to update KA's fork to at least Processingjs 1.4.3, which has been migrated to nodejs for it's build (see processing-js/processing-js@67a092cc). Input from the KA team on any plans for the processingjs sync is welcome.

Chrome, Windows7 (same behavior on IE/Firefox)
Before Patch
image

After Patch
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant