Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression error in argument buffer runtime arrays. #2060

Merged

Conversation

billhollings
Copy link
Contributor

  • Update to latest SPIRV-Cross contining the fix.
  • Modify CTS options in runcts script to avoid outputting full CTS log, and use less file caching, all to reduce memory and filespace consumption, and possibly improve performance (unrelated).
  • Update MoltenVKShaderConverter tool to include Metal 3.1 support and improved argument buffer settings (unrelated).
  • Small unrelated non-functional edits.

Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember reading that the distutils Python package is deprecated. It looks like they made good on their promise to remove it in 3.12.

@juan-lunarg
Copy link

I remember reading that the distutils Python package is deprecated. It looks like they made good on their promise to remove it in 3.12.

I'd recommend using actions/setup-python as a temporary workaround.

EX:

      - uses: actions/setup-python@v4
        with:
          python-version: '3.11'

- Update to latest SPIRV-Cross contining the fix.
- Modify CTS options in runcts script to avoid outputting full CTS log,
  and use less file caching, all to reduce memory and filespace consumption,
  and possibly improve performance (unrelated).
- Update MoltenVKShaderConverter tool to include Metal 3.1 support
  and improved argument buffer settings (unrelated).
- Force Github CI to use Python 3.11, to avoid crash in
  glslang::update_glslang_sources.py due to use of distutils,
  removed in Python 3.12 (unrelated).
- Small unrelated non-functional edits.
@billhollings billhollings force-pushed the fix-runtime-array-regression branch from 90773b2 to 40baeaa Compare November 7, 2023 19:43
@billhollings
Copy link
Contributor Author

I remember reading that the distutils Python package is deprecated. It looks like they made good on their promise to remove it in 3.12.

I'd recommend using actions/setup-python as a temporary workaround.

EX:

      - uses: actions/setup-python@v4
        with:
          python-version: '3.11'

Thanks for the detective work and suggestion!

I've reported this to glslang, and implemented the suggested patch here.

Looks like glslang has a PR ready already, so we might be flipping back soon!

@billhollings billhollings merged commit ab84de5 into KhronosGroup:main Nov 7, 2023
5 checks passed
@billhollings billhollings deleted the fix-runtime-array-regression branch November 7, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants