Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android, we're depending on MoltenVK as one of our external dependencies.
We occasionally make small modifications for our purposes that would not make sense to be merged back into the upstream.
However, ensuring consistent formatting seems to be a challenge since we can get merge conflicts from the upstream. I wanted to propose a simple clang-format (we're not attached to the formatter in any which way - we would just prefer if there were a formatter).
I am happy to remove the formatting example and for one of the main contributors to apply the formatting changes or if desired I am happy to reformat the whole project if we agree on the format.
I am a bit surprised there isn't a global formatter already - so if I missed that, please just let me know and we will use that.