-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CI, added CD #226
Updated CI, added CD #226
Conversation
Thanks for this contribution. I don't know why the CI didn't trigger here. From what I understand it should have. To get around the issue, I pushed the branch on my fork, but the CI failed: |
Hi, and thank you for looking at this. I also don't know why the CI didn't trigger, but I wouldn't be too surprised if it was for security reasons. Since this PR changed the CI script, this would be a way to execute arbitrary code on the KhronosGroup CI cluster, if it existed. The reason for the CI failure in your fork is due to the additions to the formatting checker script. The new formatting checker is incremental, i.e. only changes between the current commit and This job has run on the same commit as this PR's head, and was successful: https://github.com/StreamHPC/OpenCL-ICD-Loader/actions/runs/6339722153 |
Latest commits:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as discussed in the June 18th teleconference.
-Werror
//WX
is enabled in CI.
and..
dirs to ICD search paths when using layers.CMakeLists.txt
to be able to produce binary Debian packages usingcpack
.ocl-icd-libopencl1
)ocl-icd-opencl-dev
)cllayerinfo
executable.presubmit
workflow now.git-clang-format
.v*
tagDebSourcePkg.cmake
which is intended to run in CMake script mode. This script generates thedebian/control
,debian/changelog
and ``debian/rules` files which are required to build a Debian source package.khronos-opencl-loader
, which is also the name of the source package that is generated. Thereby the 3 binary packages are named the following:khronos-opencl-loader-libopencl1
khronos-opencl-loader-opencl-dev
khronos-opencl-loader-cllayerinfo
ocl-icd-libopencl1
,khronos-opencl-loader-libopencl1
does not conflict with other packages providing virtual packagelibopencl1
. Instead it uses the update-alternatives program so that it can be co-installed with other packages providinglibopencl1
, given that those packages are also equipped with the update-alternatives integration. This update-alternatives integration is not present in the CPack generated binary package.This PR is considered to be complete, albeit review remarks and/or changes to related PRs might warrant minor updates.