Fix utility library install #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
approved these changes
May 13, 2022
Beanavil
pushed a commit
to Beanavil/OpenCL-SDK
that referenced
this pull request
Sep 13, 2023
* Fix util lib exported name * Install util lib config headers
Beanavil
pushed a commit
to StreamHPC/OpenCL-SDK
that referenced
this pull request
Sep 26, 2023
* Fix util lib exported name * Install util lib config headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there are no consumption tests for the utility libraries (yet), it went unnoticed that consumers of the SDK can't consume the utility libraries using the advertized name
OpenCL::UtilsandOpenCL::UtilsCpp, but instead the exported names were left to be the default (target name), hence the exported names turned out to beOpenCL::OpenCLUtilsetc.It also went unnoticed, that consumers of SDK installs were missing the config header of the utility libraries from the install tree.
This PR fixes both issues, falling under the same umbrella.