Fix loader building with Gradle #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rpavlik , could you help to review this PR? Thanks. |
utzcoz
changed the title
|
@rpavlik What about this PR? If it needs a changelog fragment too, I can add a new commit for it. |
|
Haven't been in the office to look at any of these in any real detail, but yeah everything should have a changelog fragment |
|
Looks good, just needs a changelog fragment. |
The ru.vyarus.use-python will download MarkupSafe 2.1.1 on my laptopn with Python 3.8. But MarkupSafe removed soft_unicode from 2.1.0, used by jinja2:2.10.3, and it will cause importing error when running `./gradlew build` under src/loader directory. Instead of updating jinja2, this CL try to fix MarkupSafe version for loader to fix building problem. The release note of MarkupSafe is here: https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-0. Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
utzcoz
force-pushed
the
fix-loader-building-with-gradle
branch
from
c998042 to
c201601
Compare
|
Hi @rpavlik, sorry for delaying. I have rebased and added changelog for this PR. |
|
thanks very much for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ru.vyarus.use-python will download MarkupSafe 2.1.1 on my laptopn
with Python 3.8. But MarkupSafe removed soft_unicode from 2.1.0, used by
jinja2:2.10.3, and it will cause importing error when running
./gradlew buildunder src/loader directory. Instead of updating jinja2, this PRtry to fix MarkupSafe version for loader to fix building problem.
The release note of MarkupSafe is here:
https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-0.
This PR also a GitHub workflow to check OpenXR Loader building with Gradle.