build: Move CMakePresets.json to the top directory #383
Conversation
If developers want to build HelloXR on Windows platform with CMake, they might want to copy `CMakePresets.json` to the top directory for convenience. This copy command might cause dirty git diff. This CL just moves it to the top directory to remove this extra copying command for developers. Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
|
Hi @rpavlik , could you help to review this PR? Thanks. |
|
So having it there actually makes it harder to build with vscode, I regret having it there for Monado. (You have to launch vscode from a developer command prompt. Also makes it impossible to use vscode remote ssh into a Windows machine.) The only reason it's in the repo is it makes the CI easier. If it's confusing I would rather remove it than publicize it more, the preset thing isn't ready for widespread use yet, at least with vscode, and visual studio isn't much better with it. (I really should file issues with the vscode extension, etc so they can actually fix it, since the idea is nice and it works well on Linux usually.) |
|
@rpavlik I like the idea of
I think |
|
Yeah, it is "supported", but it turns off all the kit-finding the vscode extension normally does, which is why you have to launch from a dev command prompt. I'd be quite happy if we could get this resolved :) |
|
@rpavlik Another choice is to remove |
|
Looks like CLion detects |
|
Hoping for a resolution to microsoft/vscode-cmake-tools#3079 first, since the current status is really painful for me to do Windows dev with a presets file. |
|
An issue (number 1982) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1982 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
If developers want to build HelloXR on Windows platform with CMake, they might want to copy
CMakePresets.jsonto the top directory for convenience. This copy command might cause dirty git diff. This CL just moves it to the top directory to remove this extra copying command for developers.