Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jnipp: Cherry-pick https://github.com/mitchdowd/jnipp/pull/40 #426

Closed
wants to merge 1 commit into from

Conversation

nico
Copy link

@nico nico commented Sep 18, 2023

We use openxr in Chromium, and Chromium's build will break soon if this isn't addressed.

Thanks for your consideration!

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

@nico
Copy link
Author

nico commented Sep 18, 2023

(ps: I found it a bit confusing that https://github.com/nico/OpenXR-SDK told me to publish the PR here instead of over there.)

@rpavlik
Copy link
Contributor

rpavlik commented Sep 18, 2023

OpenXR-SDK is a derivative of this repo, generated automatically.

(You can run maintainer-scripts/archive-sdk.sh to make that repo from this one.)

@nico
Copy link
Author

nico commented Sep 20, 2023

Ping :)

(Once this is in, we'll have to update openxr in Chromium, and I'd love to have this done well before libc++ lands its change.)

@rpavlik-bot
Copy link
Collaborator

An issue (number 2094) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2094 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Sep 20, 2023
@rpavlik
Copy link
Contributor

rpavlik commented Oct 18, 2023

This was merged in the private monorepo, will be here upon the upcoming patch release.

@rpavlik rpavlik closed this Oct 18, 2023
@nico nico deleted the jnipp branch December 1, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants