Fix shader model 2/3 texture sampling #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can add legacy HLSL output in the test script, like we do for GLSL, Travis should be fine assuming glslangValidator can understand SM 2/3 code. |
|
Hm, KhronosGroup/glslang#362 looks like there is some 2/3 support but samplers are explicitly marked as missing. |
|
If you know how to set up appveyor, I'd be happy to merge that. |
|
Can do, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just broke. There are no tests for shader model 2/3 and I don't think we can easily test that on Travis. We could setup an appveyor script.