[SC-2189] Compiler::get_shader_resources() does not return all uniforms #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HansKristian-Work
requested changes
Aug 25, 2023
hiteshbosamiya
force-pushed
the
SC-2189
branch
from
b95d02b
to
c1e0a72
Compare
HansKristian-Work
requested changes
Aug 25, 2023
hiteshbosamiya
force-pushed
the
SC-2189
branch
from
c1e0a72
to
9f0c804
Compare
HansKristian-Work
requested changes
Aug 25, 2023
hiteshbosamiya
force-pushed
the
SC-2189
branch
from
9f0c804
to
d6b6e87
Compare
|
@HansKristian-Work, thanks for the review comments, done the requested changes, please review. |
hiteshbosamiya
force-pushed
the
SC-2189
branch
2 times, most recently
from
2e3d007
to
0eff8e7
Compare
HansKristian-Work
approved these changes
Aug 25, 2023
|
Tests fail in reflection backend. |
hiteshbosamiya
force-pushed
the
SC-2189
branch
from
0eff8e7
to
df7fa1b
Compare
|
Oops! I had missed else on line no. 1011 :-( Corrected it. Please verify. Thanks. |
hiteshbosamiya
changed the title
hiteshbosamiya
changed the title
HansKristian-Work
approved these changes
Aug 28, 2023
WhyAreAllTheseTaken
added a commit
to WhyAreAllTheseTaken/spirv_cross
that referenced
this pull request
Jul 6, 2024
ShaderResources did not include some resource types that were included in newer versions of SPIRV-Cross. One of which was `gl_plain_uniforms` which meant that GLSL uniforms that were not declared in a UBO could not be accessed or renamed. See KhronosGroup/SPIRV-Cross#2190 for details about the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.