Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spvDescriptor wrapper in spvDescriptorArray #2314

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

js6i
Copy link
Contributor

@js6i js6i commented Apr 18, 2024

That's a workaround for #2308. The diff between shader byte code with and without this change is only the getelementptr indexing order for affected variables, and looks something like this: (old above, new below)

<   %8 = getelementptr inbounds %struct.spvDescriptorSetBuffer1, ptr addrspace(1) %0, i64 0, i32 0, i64 %7, i32 0, i32 0
---
>   %8 = getelementptr inbounds %struct.spvDescriptorSetBuffer1, ptr addrspace(1) %0, i64 %7, i32 0, i64 0, i32 0, i32 0

This works around what looks like a compiler bug which can cause GPU crashes.
@HansKristian-Work HansKristian-Work merged commit 71fe131 into KhronosGroup:main Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants