Fix volatile helper invocation in non-main functions #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,18 +10,24 @@ struct main0_out | |||
| float FragColor [[color(0)]]; | |||
| }; | |||
|
|
|||
| static inline __attribute__((always_inline)) | |||
| void func(thread float& FragColor, volatile thread bool& gl_HelperInvocation) | |||
There was a problem hiding this comment.
volatile thread seems like it's asking for trouble with spilling. volatile thread is somewhat meaningless. I know this comes up because in later SPIR-V discard + helper lane is done through volatile StorageClassInput.
There was a problem hiding this comment.
Do you think we should just avoid volatile on thread variables in general?
etang-cw
force-pushed
the
VolatileHelperNonMain
branch
from
228d148
to
467ba39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our tests only passed because it operated out of the entry point and would fail if you tried to do the same thing from any other function. This makes it work no matter where it is.
Note: I couldn't think of any better names for the new variable than just adding an underscore. If anyone else has a better name, please use it.