Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c: Add HLSL option preserve_structured_buffers #2374

Conversation

chyyran
Copy link
Contributor

@chyyran chyyran commented Sep 1, 2024

expose preserve_structured_buffers HLSL option to C API as SPVC_COMPILER_OPTION_HLSL_PRESERVE_STRUCTURED_BUFFERS

@@ -745,6 +745,7 @@ typedef enum spvc_compiler_option
SPVC_COMPILER_OPTION_MSL_FORCE_FRAGMENT_WITH_SIDE_EFFECTS_EXECUTION = 89 | SPVC_COMPILER_OPTION_MSL_BIT,

SPVC_COMPILER_OPTION_HLSL_USE_ENTRY_POINT_NAME = 90 | SPVC_COMPILER_OPTION_HLSL_BIT,
SPVC_COMPILER_OPTION_HLSL_PRESERVE_STRUCTURED_BUFFERS = 91 | SPVC_COMPILER_OPTION_HLSL_BIT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as last PR. Need to bump the defines for minor version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped the API to 63 in the other PR, so #2373 must go in before this one

Otherwise fixed in 4b98efb

@chyyran chyyran force-pushed the c_hlsl_preserve_structured_buffers branch from 808f219 to 4b98efb Compare September 2, 2024 13:40
@HansKristian-Work HansKristian-Work merged commit c29a7b2 into KhronosGroup:main Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants