Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert of buffer block SPIRType with exception in get_buffer_block_flags #2376

Conversation

chyyran
Copy link
Contributor

@chyyran chyyran commented Sep 2, 2024

The assert in ParsedIR::get_buffer_block_flags is exposed to user code if Compiler::get_buffer_block_flags or spvc_compiler_get_buffer_block_decorations is called with a non-buffer variable (handle).

Particularly since the C API has no way of getting a SPIRType given only a spvc_variable_id this should not cause an assertion fail or be ignored but throw an exception.

@HansKristian-Work HansKristian-Work merged commit 6a1fb66 into KhronosGroup:main Sep 2, 2024
6 checks passed
@chyyran chyyran deleted the get_buffer_block_flags_no_assert branch October 8, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants