Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoSignedWrap decoration is emitted without declaring SPV_KHR_no_integer_wrap_decoration #120

Closed
bader opened this issue Jan 24, 2019 · 7 comments
Closed

NoSignedWrap decoration is emitted without declaring SPV_KHR_no_integer_wrap_decoration #120

bader opened this issue Jan 24, 2019 · 7 comments

Comments

@bader
Copy link
Contributor

bader commented Jan 24, 2019

(re-posting from SYCL compiler issue #2)
In cases when the translator emits NoSignedWrap decoration the SPV_KHR_no_integer_wrap_decoration isn't declared with an OpExtension.
@airlied
Copy link
Contributor

airlied commented Feb 4, 2019

@Fznamznon looks like your commit needs some fixes.

@AlexeySotkin
Copy link
Contributor

These decorations are part of the core spec now. Why do we need to declare the extension ? Maybe spirv-val needs another update.

@AlexeySotkin
Copy link
Contributor

I think the translator doesn't emit OpExtension properly in general, for any extension, not just for this one.

@kpet
Copy link
Contributor

kpet commented Mar 20, 2019

Is anyone looking at this? This issue makes it impossible to get useful feedback from the validator on many modules.

@AlexeySotkin
Copy link
Contributor

I have it in my backlog.

@kpet
Copy link
Contributor

kpet commented Mar 21, 2019

Happy to hear that :). Thanks!

AlexeySachkov added a commit to AlexeySachkov/SPIRV-LLVM-Translator that referenced this issue Apr 18, 2019
@AlexeySachkov
Generate OpExtension for SPV_KHR_no_integer_wrap_decoration
2866cc6 
Fixes KhronosGroup#120
@AlexeySachkov
Copy link
Contributor

Hi, I'm working on extensions support in SPIRV-Translator right now, feel free to review and leave your feedback in #175

@kpet kpet mentioned this issue Apr 18, 2019
Merged
AlexeySachkov added a commit to AlexeySachkov/SPIRV-LLVM-Translator that referenced this issue Apr 23, 2019
@AlexeySachkov
Generate OpExtension for SPV_KHR_no_integer_wrap_decoration
1d32133 
Fixes KhronosGroup#120
@svenvh svenvh closed this as completed in 7be209e Apr 24, 2019
AlexeySotkin pushed a commit to AlexeySotkin/SPIRV-LLVM-Translator that referenced this issue May 30, 2019
@AlexeySachkov @AlexeySotkin
Generate OpExtension for SPV_KHR_no_integer_wrap_decoration
19db731 
Fixes KhronosGroup#120
AlexeySotkin pushed a commit that referenced this issue May 31, 2019
@AlexeySachkov @AlexeySotkin
Generate OpExtension for SPV_KHR_no_integer_wrap_decoration
efbf0af 
Fixes #120
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this issue Sep 1, 2022
@iclsrc @linayu118211
Resolve of merge (conflict) 3c4c808 Improve backward compatibility fo…
eed452b 
…r DISubRange (KhronosGroup#1400) '"master"' -> '"xmain-web"' (KhronosGroup#120)

* Resolve of merge (conflict) 3c4c808 Improve backward compatibility for DISubRange (KhronosGroup#1400) '"master"' -> '"xmain-web"'

  CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVToLLVMDbgTran.cpp

  commit 3c4c808
  Author: Nikita <nikita.kornev@intel.com>
  Date:   Wed Feb 9 17:09:57 2022 +0300

      Improve backward compatibility for DISubRange (KhronosGroup#1400)

      If the SPIR-V file was generated by an older version of the translator, Ops may
      not contain the LowerBound

* Conflict resolution

Co-authored-by: iclsrc <ia.compiler.tools.git@intel.com>
Co-authored-by: Lina Yu <lina.yu@intel.com>
vmaksimo pushed a commit to vmaksimo/SPIRV-LLVM-Translator that referenced this issue Sep 1, 2022
@linayu118211
Merge of resolve of merge (conflict) 3c4c808 Improve backward compati…
8ef4e85 
…bility for DISubRange (KhronosGroup#1400) '"master"' -> '"xmain-web"' (KhronosGroup#120)

* Resolve of merge (conflict) 3c4c808 Improve backward compatibility for DISubRange (KhronosGroup#1400) '"master"' -> '"xmain-web"'

  CONFLICT (content): Merge conflict in lib/SPIRV/SPIRVToLLVMDbgTran.cpp

  commit 3c4c808
  Author: Nikita <nikita.kornev@intel.com>
  Date:   Wed Feb 9 17:09:57 2022 +0300

      Improve backward compatibility for DISubRange (KhronosGroup#1400)

      If the SPIR-V file was generated by an older version of the translator, Ops may
      not contain the LowerBound

* Conflict resolution

Co-authored-by: iclsrc <ia.compiler.tools.git@intel.com>
Co-authored-by: Lina Yu <lina.yu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bader @kpet @airlied @AlexeySachkov @AlexeySotkin