Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS-Fuzz: ASSERT: false && "Definition is not registered." #4731

Closed
afd opened this issue Feb 18, 2022 · 0 comments · Fixed by #4840
Closed

OSS-Fuzz: ASSERT: false && "Definition is not registered." #4731

afd opened this issue Feb 18, 2022 · 0 comments · Fixed by #4840
Assignees
@s-perron
Labels
component:optimization fuzzer-found-issue A note that an issue was found using a fuzzer tool (e.g. GraphicsFuzz)

Comments

@afd
Copy link
Contributor

afd commented Feb 18, 2022

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42190

@s-perron for info.
@afd afd added component:optimization fuzzer-found-issue A note that an issue was found using a fuzzer tool (e.g. GraphicsFuzz) labels Feb 18, 2022
@s-perron s-perron self-assigned this Feb 28, 2022
@s-perron s-perron mentioned this issue Jul 4, 2022
Merged
s-perron added a commit to s-perron/SPIRV-Tools that referenced this issue Jul 4, 2022
@s-perron
DCE: clean up the cfg for all functions that were processed.
e57a343 
Which functions are processed is determined by which ones are on the
call tree from the entry points before dead code is removed.  So it is
possible that a function is process because it is called from an entry
point, but the CFG is not cleaned up because the call to the function
was removed.

The fix is to process and cleanup every function in the module.  Since
all of the dead functions would have already been removed in an earlier
step of DCE, it should not make a different in compile time.

Fixes KhronosGroup#4731
s-perron added a commit to s-perron/SPIRV-Tools that referenced this issue Jul 4, 2022
@s-perron
DCE: clean up the cfg for all functions that were processed.
2873e69 
Which functions are processed is determined by which ones are on the
call tree from the entry points before dead code is removed.  So it is
possible that a function is process because it is called from an entry
point, but the CFG is not cleaned up because the call to the function
was removed.

The fix is to process and cleanup every function in the module.  Since
all of the dead functions would have already been removed in an earlier
step of DCE, it should not make a different in compile time.

Fixes KhronosGroup#4731
s-perron added a commit that referenced this issue Jul 5, 2022
@s-perron
DCE: clean up the cfg for all functions that were processed. (#4840)
32622ba 
Which functions are processed is determined by which ones are on the
call tree from the entry points before dead code is removed.  So it is
possible that a function is process because it is called from an entry
point, but the CFG is not cleaned up because the call to the function
was removed.

The fix is to process and cleanup every function in the module.  Since
all of the dead functions would have already been removed in an earlier
step of DCE, it should not make a different in compile time.

Fixes #4731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-perron s-perron

Labels
component:optimization fuzzer-found-issue A note that an issue was found using a fuzzer tool (e.g. GraphicsFuzz)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DCE: clean up the cfg for all functions that were processed. s-perron/SPIRV-Tools
2 participants
@afd @s-perron