Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-val: Add initial SPV_EXT_mesh_shader validation #4924

Merged
merged 7 commits into from
Sep 23, 2022
Merged

spirv-val: Add initial SPV_EXT_mesh_shader validation #4924

merged 7 commits into from
Sep 23, 2022

Conversation

sjfricke
Copy link
Contributor

@sjfricke sjfricke commented Sep 7, 2022

Adds a good amount of validation from #4919

@sjfricke sjfricke mentioned this pull request Sep 7, 2022
Open
@sjfricke sjfricke force-pushed the sjfricke-meshshader branch from de5eded to 9de4b5c Compare September 7, 2022 09:08
@dgkoch dgkoch mentioned this pull request Sep 7, 2022
Open
19 tasks
@sjfricke sjfricke force-pushed the sjfricke-meshshader branch from 9de4b5c to 8a9b9be Compare September 8, 2022 13:40
@sjfricke sjfricke mentioned this pull request Sep 9, 2022
Merged
@sjfricke
Copy link
Contributor Author

rebased so will pass CI with new glslang

alan-baker
alan-baker requested changes Sep 16, 2022
View reviewed changes
source/val/validate_mesh_shading.cpp Show resolved Hide resolved
source/val/validate_mesh_shading.cpp Outdated Show resolved Hide resolved
source/val/validation_state.cpp Outdated Show resolved Hide resolved
alan-baker
alan-baker requested changes Sep 19, 2022
View reviewed changes
source/val/validate_mesh_shading.cpp Outdated Show resolved Hide resolved
alan-baker
alan-baker requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realize the bot failure is likely a bug.

source/val/validate_mode_setting.cpp Outdated Show resolved Hide resolved
@alan-baker
Copy link
Contributor

Sorry, I think this needs a rebase now to satisfy the bots.

@sjfricke
Copy link
Contributor Author

@alan-baker 👍

@alan-baker alan-baker merged commit b53d7a8 into KhronosGroup:master Sep 23, 2022
@sjfricke sjfricke deleted the sjfricke-meshshader branch October 20, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjfricke @alan-baker @kokoro-team