spirv-opt: Add const folding for CompositeInsert #4943
Conversation
|
@dnovillo - can this get a CI dispatch, this is preventing a real world app from using the Vulkan Validation layers (since it uses this pass and the shader had a |
source/opt/const_folding_rules.cpp
Outdated
| for (size_t i = chain.size(); i > 0; i--) { | ||
| // Need to insert any previous instruction into the module first | ||
| // TODO - Is there a better way to find this position | ||
| Module::inst_iterator* pos = nullptr; |
There was a problem hiding this comment.
You could also insert at the top of the constants declared in the module, I think.
There was a problem hiding this comment.
Ya, I guess I was going for keeping the instructions next to each other, but I also like the idea of making the code simpler and just putting at the top (since I should have an easy reference to its iterator)
There was a problem hiding this comment.
So I tried this approach and the issue currently there is only an iterator to the Types which ends up inserting it above where the types are declared. Updated comment and think this is the best way currently to find the instruction
sjfricke
force-pushed
the
sjfricke-stackedop2
branch
from
0fb4bae to
a1cbaf5
Compare
sjfricke
force-pushed
the
sjfricke-stackedop2
branch
from
a1cbaf5 to
1956d45
Compare
sjfricke
force-pushed
the
sjfricke-stackedop2
branch
from
1956d45 to
9262600
Compare
Currently doing a
OpSpecConstantOp %x CompositeInsertwould segfaultThis change injects the extra needed
OpConstantCompositein order to properly handle foldingCompositeInsert