Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent eliminating case constructs in block merging #4976

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

alan-baker
Copy link
Contributor

@alan-baker alan-baker commented Oct 27, 2022

Fixes #4918

  • Prevent block merging from producing an invalid case construct by merging a switch target/default with another construct's merge or continue block
  • This is to satisfy the structural dominance requirement between the switch header and the case constructs

Copy link
Contributor

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (modulus CI passing the format check)

Fixes KhronosGroup#4918

* Prevent block merging from producing an invalid case construct by
  merging a switch target/default with another construct's merge or
  continue block
* This is to satisfy the structural dominance requirement between the
  switch header and the case constructs
@alan-baker alan-baker merged commit a52de68 into KhronosGroup:master Oct 28, 2022
@alan-baker alan-baker deleted the block-merge-4918 branch October 28, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimizer: Invalid CFG generated for odd switch break pattern
2 participants