Add validation support for SPV_NV_shader_invocation_reorder. #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
cc : @dgkoch @johnkslang or @dneto0 to review |
|
This PR needs rebased. |
|
@alan-baker : Rebased, please re-review |
|
Ping @alan-baker , can you take a look |
alan-baker
reviewed
Nov 21, 2022
|
@alan-baker : I have fixed the build bot failures. Can you retrigger? |
|
Had missed a clang format, everything is now green except the ndk-build which complains about undefined references @alan-baker : Can you assist? I am not clear why it would break only on android/ndk build |
|
You might have forgotten to update other build systems. It looks like only cmakelists are updated. The android.mk needs updated I expect. Bazel is probably glob'ing all the files already. |
alan-baker
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPV spec : KhronosGroup/SPIRV-Registry#175
GLSL spec : KhronosGroup/GLSL#196