spirv-opt: Fix OpCompositeInsert with Null Constant #5008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5005
Now when folding
OpCompositeInsert
with a nullcomposite
it correctly handles it.The main issue is
class NullConstant : public Constant {}
is not aCompositeConstant
because sometimesOpConstantNull
can be either. For cases where there is aOpConstantNull %v3float
it will turn it into aOpConstantComposite %v3float %null %null %null
before continuing with the logic as normalcc @sugoi1 I hope this fixes everything now